Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(web): update nextFrame precision for perf #440

Merged
merged 1 commit into from
Jan 3, 2025
Merged

perf(web): update nextFrame precision for perf #440

merged 1 commit into from
Jan 3, 2025

Conversation

theashraf
Copy link
Member

Description

This update rounds nextFrame to two decimal places for smoother animations and improved performance.

Type of change

@lottiefiles/dotlottie-web

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2025

🦋 Changeset detected

Latest commit: 7f69eb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@lottiefiles/dotlottie-web Minor
@lottiefiles/dotlottie-react Patch
@lottiefiles/dotlottie-solid Patch
@lottiefiles/dotlottie-svelte Patch
@lottiefiles/dotlottie-vue Patch
@lottiefiles/dotlottie-wc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@theashraf theashraf changed the title perf(web): update currentFrame precision for perf perf(web): update nextFrame precision for perf Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report for @lottiefiles/dotlottie-web (packages/web)

Status Category Percentage Covered / Total
🟢 Lines 53.06% (🎯 52%) 562 / 1059
🟢 Statements 51.85% (🎯 51%) 588 / 1134
🟢 Functions 52.38% (🎯 52%) 143 / 273
🟢 Branches 58.58% (🎯 58%) 389 / 664
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/web/src/dotlottie.ts 68.89% 65.31% 61.29% 72.06% 135-142, 165, 206-210, 245, 259, 274, 304, 327, 331, 408, 414, 430, 434, 469, 484-485, 500, 522-525, 558, 563, 573, 601-606, 610, 615-618, 625-639, 709-714, 718, 739, 774, 801-845, 849, 859-982, 998-1069
Generated in workflow #1601 for commit 7f69eb8 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report for @lottiefiles/dotlottie-react (packages/react)

Status Category Percentage Covered / Total
🟢 Lines 97.46% (🎯 95%) 77 / 79
🟢 Statements 97.61% (🎯 95%) 82 / 84
🟢 Functions 100% (🎯 95%) 27 / 27
🟢 Branches 90% (🎯 89%) 45 / 50
File CoverageNo changed files found.
Generated in workflow #1601 for commit 7f69eb8 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Coverage Report for @lottiefiles/dotlottie-wc (packages/wc)

Status Category Percentage Covered / Total
🟢 Lines 98.46% (🎯 98%) 64 / 65
🟢 Statements 98.52% (🎯 98%) 67 / 68
🟢 Functions 100% (🎯 100%) 10 / 10
🟢 Branches 94.64% (🎯 94%) 53 / 56
File CoverageNo changed files found.
Generated in workflow #1601 for commit 7f69eb8 by the Vitest Coverage Report Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
@lottiefiles/dotlottie-web 38.35 KB (+0.15% 🔺) 767 ms (+0.15% 🔺) 3.3 s (-22.62% 🔽) 4.1 s
@lottiefiles/dotlottie-web WASM 400.03 KB (0%) 8.1 s (0%) 0 ms (+100% 🔺) 8.1 s
@lottiefiles/dotlottie-react 41.25 KB (+0.06% 🔺) 825 ms (+0.06% 🔺) 1.4 s (+8.26% 🔺) 2.3 s
@lottiefiles/dotlottie-vue 45.22 KB (+0.13% 🔺) 905 ms (+0.13% 🔺) 2.4 s (+60.38% 🔺) 3.3 s
@lottiefiles/dotlottie-wc 45.62 KB (-0.1% 🔽) 913 ms (-0.1% 🔽) 1.8 s (+16.04% 🔺) 2.7 s
@lottiefiles/dotlottie-svelte 45.78 KB (+0.06% 🔺) 916 ms (+0.06% 🔺) 2.8 s (+117.22% 🔺) 3.7 s
@lottiefiles/dotlottie-solid 44.68 KB (+0.09% 🔺) 894 ms (+0.09% 🔺) 975 ms (-22.6% 🔽) 1.9 s

afsalz
afsalz approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@afsalz afsalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@theashraf theashraf merged commit 8ef9888 into main Jan 3, 2025
7 checks passed
@theashraf theashraf deleted the perf/frame-precision branch January 3, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsalz afsalz afsalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theashraf @afsalz